Use ES6 + Remove jQuery + Improved css#134
Closed
mauriciabad wants to merge 1 commit into
Closed
Conversation
mauriciabad
changed the title
Contributor
Author
|
|
Member
|
@mauriciabad thanks, I'll take a look at this. |
Contributor
Author
|
@darrachequesne any news? |
|
Nice! |
Contributor
Author
Contributor
Author
|
I see that jQuery was already removed, which was the main point of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nowadays jQuery is not needed: it's confusing for the newbies and adds extra dependencies.
I also made a Pull Request into the chat example code.
socketio/chat-example#34
The videos should be recorded again because of the style change, or only apply the removal of jQuery and discard the style change.
BTW: I love socket.io, great work! 😄